Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash/zsh completions for cdktf-cli commands #676

Closed
ansgarm opened this issue May 3, 2021 · 4 comments
Closed

bash/zsh completions for cdktf-cli commands #676

ansgarm opened this issue May 3, 2021 · 4 comments
Assignees
Labels
cdktf-cli enhancement New feature or request size/medium estimated < 1 week
Milestone

Comments

@ansgarm
Copy link
Member

ansgarm commented May 3, 2021

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Yargs supports specifying completions for commands and arguments. This would be really useful to autocomplete the stacks when doing e.g. a cdktf deploy [stack].

References

@ansgarm ansgarm added enhancement New feature or request cdktf-cli labels May 3, 2021
@skorfmann
Copy link
Contributor

That sounds great!

@danieldreier danieldreier added this to the 0.5 milestone Jun 25, 2021
@DanielMSchmidt
Copy link
Contributor

I failed getting any autocompletion output out of yargs at cli-autocompletion I am not super familiar with this kind of shell interaction, so I'm probably not the ideal person for this task

@ansgarm
Copy link
Member Author

ansgarm commented Sep 2, 2021

Support for shell completions has been introduced via #943.
Currently yargs does not support auto completing choices (e.g. typescript, go, ... for --language). I opened a PR for that and as soon as that gets merged and released we can update to that yargs version to improve our completion support.

@ansgarm ansgarm closed this as completed Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cdktf-cli enhancement New feature or request size/medium estimated < 1 week
Projects
None yet
Development

No branches or pull requests

4 participants