feat: autocomplete choices for options #2018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR introduces support for auto completing choices if an option has been specified which has choices but no value has been selected yet. For example:
when the option has been specified like this: (source)
Background
We use
yargs
for the CDK for Terraform and wanted to introduce support for shell completion. As we wanted to offer support for auto completing choices for options, I figured I'd do a PR instead of building a custom completion handler in multiple places.If there's anything I can do to get this merged, please tell me!
P.S. It also fixes #2016 because that caused the build to fail for me and there's no
package-lock.json
or alike.