Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inset-area() function BCD #23098

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

chrisdavidmills
Copy link
Collaborator

Summary

CSS Anchor Positioning is set to be released in Chrome 125 (see the associated Chrome Status entry).

We added most of the BCD in a different PR, but we missed the inset-area() function, which is a possible value for the position-try-options property. This PR adds that

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label May 15, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I look at https://developer.mozilla.org/en-US/docs/Web/CSS/transform-function/translate3d then we have a sub page on MDN and the compat data lives under css.types.transform-function.translate3d.

Would you model inset-area() after this pattern? like:

Or maybe I'm missing something. CSS docs and its structure is not quite my usual avenue. :)

@chrisdavidmills
Copy link
Collaborator Author

If I look at https://developer.mozilla.org/en-US/docs/Web/CSS/transform-function/translate3d then we have a sub page on MDN and the compat data lives under css.types.transform-function.translate3d.

Would you model inset-area() after this pattern? like:

* https://developer.mozilla.org/en-US/docs/Web/CSS/position-try-options/inset-area

* css.types.position-try-options.inset-area

Or maybe I'm missing something. CSS docs and its structure is not quite my usual avenue. :)

@Elchi3 ah, this is a good point. I arrived at doing it this way because I saw the https://developer.mozilla.org/en-US/docs/Web/CSS/fit-content_function page, decided to follow that pattern for the inset-area() function page slug, and then thought that it would also have its own separate BCD entry.

But I've now seen that fit-content() has its entry at css.properties.width.fit-content_function. I'll update this to follow that pattern too, and put it under css.types.position-try-options.inset-area. An advantage is that you'll also get that entry appearing under the position-try-options page BCD, which will be useful.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris, I like this a lot better.

@Elchi3 Elchi3 merged commit fdaa23a into mdn:main May 28, 2024
6 checks passed
@chrisdavidmills chrisdavidmills deleted the inset-area-function branch May 28, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants