Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"incognito": "split" support #23124

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented May 17, 2024

Summary

Address browser compatibility documentation requirements for Bug 1876924 Treat "incognito":"split" as a warning instead of a hard error

Related issues

Related MDN changes: mdn/content#33661

@rebloor rebloor added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label May 17, 2024
@rebloor rebloor requested review from dotproto and Rob--W May 17, 2024 17:53
@rebloor rebloor self-assigned this May 17, 2024
"version_added": false,
"impl_url": "https://bugzil.la/1380812"
"version_added": "127",
"notes": "Split mode is not supported in Firefox. Extensions using this value are treated as requesting \"incognito\":\"not_allowed\"."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you somehow link https://bugzilla.mozilla.org/show_bug.cgi?id=1380812 ? Whether from the mdn/content or BCD?

Can impl_url render meaningfully here?

This is effectively a partial_impl at best or just not supported.

Safari doesn't support incognito:split either, so their behavior is comparable to the default incognito:spanning mode.

Firefox was special as in it rejected values of incognito:split because it did recognize the incognito key and accepted only recognized values (spanning and not_allowed). Because the implementation rejected unrecognized values, incognito:split could not be installed. The change in 127 is to allow the extension to be installed, but to be overly cautious the default value is not_allowed.

@rebloor rebloor requested a review from Rob--W May 21, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants