Update NodeJS data for DOMException API #23125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates and corrects version values for NodeJS for the `DOMException` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.10.6), using results collected via [UnJS' runtime-compat project](https://github.com/unjs/runtime-compat). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/DOMException
queengooborg
added
the
data:api 🐇
foolip
reviewed
May 21, 2024
api/DOMException.json
Outdated
| @@ -105,6 +108,9 @@ | |||
| "ie": { | |||
| "version_added": "9" | |||
| }, | |||
| "nodejs": { | |||
| "version_added": false | |||
There was a problem hiding this comment.
This doesn't seem right, new DOMException('message').code is 0 in node v20.12.1.
There was a problem hiding this comment.
Hmm, not sure what's going on with this test then. Reverting!
foolip
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and corrects version values for NodeJS for the
DOMExceptionAPI. The data comes from the mdn-bcd-collector project (v10.10.6), using results collected via UnJS' runtime-compat project.Check out the collector's guide on how to review this PR.
Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/DOMException