-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass through functions[].schedule property to ZISI #3761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We'll need two additional things:
-
Add
schedule
to the list of function configuration properties (https://github.com/netlify/build/blob/main/packages/config/src/functions_config.js#L52-L58) -
Add validation to the
schedule
property (see https://github.com/netlify/build/blob/main/packages/config/src/validate/validations.js) and accompanying tests
Not blocking this PR, but more of a general discussion: do you think we should just forward LaunchDarkly flags from |
I'm not sure, to be honest. We're doing more than just passing flags through in I'd be more in favour of that if zip-it-and-ship-it was always called from Netlify Build, but that's not the case since CLI interacts with it directly. So I think it's good that zip-it-and-ship-it and Netlify Build have their own set of feature flags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've added a couple of small comments, with the only blocker being the one about the test.
{ | ||
property: 'functions.*.schedule', | ||
check: isValidCronExpression, | ||
message: 'must be a valid cron expression (see https://ntl.fyi/cron-syntax).', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Related to
schedule
property into manifest zip-it-and-ship-it#768.This PR passes through the
functions[...].schedule
field to ZISI.TODO: