fix: bump minimum node version to v18 #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browniebroke
force-pushed
the
gatsby-v5
branch
from
be43df9
to
e643665
Compare
browniebroke
changed the title
Merged
|
Hi @browniebroke , Thanks for opening up a pull request! We've made the changes needed to in order to support Gatsby 5 within this plugin (released as part of Assuming you also need the related gatsby v5 support changes in the @netlify/plugin-gatsby, those will be released as part of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to upgrade my site to Gatsby v5 and noticed this plugin was blocking me.
Sadly I cannot confirm whether this work on my site since I'm also blocked by another plugin, but sharing in case other can test/pick up the work from here.EDIT: other plugin has been updated, my site deploy seems to work and the headers are correctly picked up
EDIT 2: This was initially about upgrading to Gatsby v5 but that part was superseded in #198. However, Gatsby v5 only supports node 18, so the minimum node version for this plugin can also be bumped.
Relates #195