New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: convert small ts files in node_dependencies to ts #710
Conversation
⏱ Benchmark resultsComparing with bde1d22 largeDepsZisi: 1m 0.7s⬇️ 8.05% decrease vs. bde1d22
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added just minor comments. I understand that one file leads to another when you're migrating to TS, but I'd really like to take smaller steps, if possible.
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔈 🕺🏻
- Summary
(supercedes #683)
This PR converts the first couple of files from javascript to typescript.
- Test plan
- A picture of a cute animal (not mandatory but encouraged)