Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert small ts files in node_dependencies to ts #710

Merged
merged 10 commits into from Oct 11, 2021

Conversation

netlify-team-account-1
Copy link
Contributor

- Summary

(supercedes #683)

This PR converts the first couple of files from javascript to typescript.

- Test plan

- A picture of a cute animal (not mandatory but encouraged)

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

⏱ Benchmark results

Comparing with bde1d22

largeDepsZisi: 1m 0.7s

⬇️ 8.05% decrease vs. bde1d22

^                         1m 22.8s                                                                        
│                           ┌──┐                                                                          
│                           |  |                                                                          
│         1m 11.5s          |  |  1m 10.7s1m 10.2s                                                        
│           ┌──┐            |  |    ┌──┐    ┌──┐          1m 4.9s 1m 7.5s                 1m 7.7s         
│ ──────────┼──┼────────────┼──┼────┼──┼────┼──┼────────────┌──┐────┌──┐────────────────────┌──┐──1m 0.7s─
│  58.2s    |  |   55.9s    |  |    |  |    |  |   57.8s    |  |    |  |   59.5s    59s     |  |    ┌──┐  
│   ┌──┐    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    ┌──┐    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added just minor comments. I understand that one file leads to another when you're migrating to TS, but I'd really like to take smaller steps, if possible.

src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔈 🕺🏻

@kodiakhq kodiakhq bot merged commit 1d31869 into main Oct 11, 2021
@kodiakhq kodiakhq bot deleted the typescript-migrate-raichu branch October 11, 2021 10:55
@netlify-team-account-1 netlify-team-account-1 changed the title feat: convert small ts files in node_dependencies to ts chore: convert small ts files in node_dependencies to ts Oct 12, 2021
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants