This repository has been archived by the owner on May 22, 2024. It is now read-only.
chore: convert small ts files in node_dependencies to ts #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
⏱ Benchmark resultsComparing with bde1d22 largeDepsZisi: 1m 0.7s⬇️ 8.05% decrease vs. bde1d22 Legend
|
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
netlify-team-account-1
changed the title
github-actions
bot
added
the
type: chore
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…it-and-ship-it#710) * chore: migrate a bunch of files to typescript * chore: tighten typescript rules * chore: package is a reserved keyword * Update src/runtimes/node/bundlers/esbuild/plugin_native_modules.js Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com> * Update src/runtimes/node/bundlers/esbuild/plugin_native_modules.js Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com> * Update src/runtimes/node/bundlers/esbuild/plugin_native_modules.js Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com> * chore: add gypfile, files and binary fields to PackageJSON * chore: replace module.exports * chore: use export {} Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com> Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
(supercedes #683)
This PR converts the first couple of files from javascript to typescript.
- Test plan
- A picture of a cute animal (not mandatory but encouraged)