New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NFT bundler #713
Conversation
⏱ Benchmark resultsComparing with 413e5dc largeDepsEsbuild: 12.2s⬇️ 11.63% decrease vs. 413e5dc
Legend
largeDepsZisi: 1m 6s⬇️ 10.34% decrease vs. 413e5dc
Legend
|
@@ -7,20 +7,32 @@ const { platform } = require('process') | |||
* @returns {(name: string, matrix: M[], runner: (opts: O, t: import("ava").ExecutionContext) => any) => void} | |||
*/ | |||
const makeTestMany = (test, matrix) => { | |||
const filteredVariations = env.ZISI_FILTER_VARIATIONS ? env.ZISI_FILTER_VARIATIONS.split(',') : [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a convenience method for running only the variations specified in the ZISI_FILTER_VARIATIONS
environment variable, if found.
const testTitle = `${title} [${name}]` | ||
|
||
if (name.startsWith('todo:')) { | ||
testFunction.todo(testTitle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows us to flag a variation as needing to be implemented. For example:
testMany('some test', ['bundler_default', 'todo:bundler_esbuild'], () => {})
248e3a9
to
bf8a1ea
Compare
This property will likely get deprecated in a future version
# Increasing the maximum number of open files. See: | ||
# https://github.com/actions/virtual-environments/issues/268 | ||
- name: Increase open file limit | ||
run: sudo ulimit -Sn 65536 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this might need to have the shell specified sudo /bin/bash -c "ulimit -l 65536"
. it will only work if processes are started from same shell, which i think they will be cos it's inside the same job
The CI workflow on Windows hasn't completed because of https://www.githubstatus.com/incidents/81lpnf07bm1q. I ran it in a VM and it passed, so I'm force-merging this. |
- Summary
Adds Node File Tracer as a bundler option.
This is an initial implementation with some features still missing, such as support for TypeScript and ES Modules.
- Test plan
Added a new variation to the test matrix.
- A picture of a cute animal (not mandatory but encouraged)