This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: add NFT bundler #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
⏱ Benchmark resultsComparing with 413e5dc largeDepsEsbuild: 12.2s⬇️ 11.63% decrease vs. 413e5dc Legend
largeDepsZisi: 1m 6s⬇️ 10.34% decrease vs. 413e5dc Legend
|
eduardoboucas
commented
Oct 8, 2021
| @@ -7,20 +7,32 @@ const { platform } = require('process') | |||
| * @returns {(name: string, matrix: M[], runner: (opts: O, t: import("ava").ExecutionContext) => any) => void} | |||
| */ | |||
| const makeTestMany = (test, matrix) => { | |||
| const filteredVariations = env.ZISI_FILTER_VARIATIONS ? env.ZISI_FILTER_VARIATIONS.split(',') : [] | |||
There was a problem hiding this comment.
This is a convenience method for running only the variations specified in the ZISI_FILTER_VARIATIONS environment variable, if found.
eduardoboucas
commented
Oct 8, 2021
| const testTitle = `${title} [${name}]` | ||
|
|
||
| if (name.startsWith('todo:')) { | ||
| testFunction.todo(testTitle) |
There was a problem hiding this comment.
This allows us to flag a variation as needing to be implemented. For example:
testMany('some test', ['bundler_default', 'todo:bundler_esbuild'], () => {})
netlify-team-account-1
approved these changes
Oct 11, 2021
ascorbic
reviewed
Oct 11, 2021
This was referenced Oct 12, 2021
eduardoboucas
force-pushed
the
feat/nft-bundler
branch
from
248e3a9
to
bf8a1ea
Compare
This property will likely get deprecated in a future version
ingride
reviewed
Oct 13, 2021
| # Increasing the maximum number of open files. See: | ||
| # https://github.com/actions/virtual-environments/issues/268 | ||
| - name: Increase open file limit | ||
| run: sudo ulimit -Sn 65536 |
There was a problem hiding this comment.
i think this might need to have the shell specified sudo /bin/bash -c "ulimit -l 65536". it will only work if processes are started from same shell, which i think they will be cos it's inside the same job
|
The CI workflow on Windows hasn't completed because of https://www.githubstatus.com/incidents/81lpnf07bm1q. I ran it in a VM and it passed, so I'm force-merging this. |
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
* feat: add NFT bundler * chore: add benchmark for NFT * chore: fix usage of `basePath` in tests * refactor: add `basePath` to `listFunctionsFiles` * chore: add `repositoryRoot` test * chore: remove docs for `repositoryRoot` This property will likely get deprecated in a future version * feat: use `repositoryRoot` in NFT * refactor: use `repositoryRoot` in `getSrcFiles` * chore: increase maximum number of open files * chore: increase open file limit in MacOS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Adds Node File Tracer as a bundler option.
This is an initial implementation with some features still missing, such as support for TypeScript and ES Modules.
- Test plan
Added a new variation to the test matrix.
- A picture of a cute animal (not mandatory but encouraged)