Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Manifest type #770

Merged
merged 11 commits into from Oct 26, 2021
Merged

feat: add Manifest type #770

merged 11 commits into from Oct 26, 2021

Conversation

eduardoboucas
Copy link
Member

- Summary

Adds a Manifest type to formally define the format of the manifest file.

- Test plan

N/A

- A picture of a cute animal (not mandatory but encouraged)

screen-0

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2021 •
edited

⏱ Benchmark results

largeDepsEsbuild: 8.5s

^   8.5s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T
Legend
  • T (current commit): 8.5s

largeDepsNft: 57.5s

^  57.5s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T
Legend
  • T (current commit): 57.5s

largeDepsZisi: 1m 5.5s

^ 1m 5.5s 
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T
Legend
  • T (current commit): 1m 5.5s

@netlify-team-account-1
Copy link
Contributor

netlify-team-account-1 commented Oct 26, 2021 •
edited

I merged in the changes from #768 to prevent merge conflicts. we should probably merge it before.

@eduardoboucas
Copy link
Member Author

I merged in the changes from #768 to prevent merge conflicts. we should probably merge it before.

Feel free to merge both in the order you think is best.

@kodiakhq kodiakhq bot merged commit a78451c into main Oct 26, 2021
@kodiakhq kodiakhq bot deleted the feat/manifest-type branch October 26, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netlify-team-account-1 netlify-team-account-1 netlify-team-account-1 approved these changes

Assignees
No one assigned
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduardoboucas @netlify-team-account-1