Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

feat: add Manifest type #770

Merged
merged 11 commits into from
Oct 26, 2021
Merged

feat: add Manifest type #770

merged 11 commits into from
Oct 26, 2021

Conversation

eduardoboucas
Copy link
Member

- Summary

Adds a Manifest type to formally define the format of the manifest file.

- Test plan

N/A

- A picture of a cute animal (not mandatory but encouraged)

screen-0

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2021

⏱ Benchmark results

largeDepsEsbuild: 8.5s

^   8.5s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 8.5s

largeDepsNft: 57.5s

^  57.5s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 57.5s

largeDepsZisi: 1m 5.5s

^ 1m 5.5s 
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 1m 5.5s

@netlify-team-account-1
Copy link
Contributor

netlify-team-account-1 commented Oct 26, 2021

I merged in the changes from #768 to prevent merge conflicts. we should probably merge it before.

@eduardoboucas
Copy link
Member Author

I merged in the changes from #768 to prevent merge conflicts. we should probably merge it before.

Feel free to merge both in the order you think is best.

@kodiakhq kodiakhq bot merged commit a78451c into main Oct 26, 2021
@kodiakhq kodiakhq bot deleted the feat/manifest-type branch October 26, 2021 09:49
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
* chore: add for schedule property

* feat: output `schedule` property into functions manifest

* feat: add Manifest type

* Update src/manifest.ts

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

* Update main.js

* chore: integrate into existing manifest test

* chore: remove .only

* chore: merge in schedule type

Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com>
Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants