refactor: pass array to nft.ignore #1480

Skn0tt · 2023-06-27T15:45:28Z

🎉 Thanks for submitting a pull request! 🎉

Summary

We're testing this behaviour in this test:

zip-it-and-ship-it/tests/main.test.ts

Lines 198 to 216 in 1b859a4

    
           testMany('Ignore some excluded node modules', [...allBundleConfigs], async (options) => { 
        
             const fixtureName = 'node-module-excluded' 
        
             const opts = merge(options, { 
        
               basePath: join(FIXTURES_DIR, fixtureName), 
        
             }) 
        
             const { files } = await zipNode(fixtureName, { opts }) 
        
             await expect(`${files[0].unzipPath}/node_modules/aws-sdk`).not.toPathExist() 
        
             try { 
        
               const func = await importFunctionFile(`${files[0].unzipPath}/function.js`) 
        
               func() 
        
               expect.fail('Running the function should fail due to the missing module') 
        
             } catch (error) { 
        
               expect(error.code).toBe('MODULE_NOT_FOUND') 
        
             } 
        
           })

So the refactoring shouldn't have any breaking change. I'm hoping this might improve performance - or at the very least, reduce cognitive complexity when reading 🤷

For us to review and ship your PR efficiently, please perform the following steps:

Open a bug/issue before writing your code 🧑‍💻.
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
Read the contribution guidelines 📖. This ensures your code follows our style guide and
passes our tests.
Update or add tests (if any source code was changed or added) 🧪
Update or add documentation (if features were changed or added) 📝
Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

github-actions · 2023-06-27T15:48:16Z

⏱ Benchmark results

Comparing with 646c1cc

largeDepsEsbuild: 3.4s

⬆️ 24.92% increase vs. 646c1cc

^                                                   3.6s                                                  
│                                                   ┌──┐                            3.4s            3.4s  
│                                           3.2s    |  |                    3.2s    ┌──┐            ┌──┐  
│                                           ┌──┐    |  |     3s             ┌──┐    |  |            |▒▒|  
│   2.8s                                    |  |    |  |    ┌──┐            |  |    |  |            |▒▒|  
│ ──┌──┐────2.7s────────────────────2.6s────┼──┼────┼──┼────┼──┼────────────┼──┼────┼──┼────────────|▒▒|──
│   |  |    ┌──┐    2.4s    2.5s    ┌──┐    |  |    |  |    |  |    2.4s    |  |    |  |    2.5s    |▒▒|  
│   |  |    |  |    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    ┌──┐    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (271729d): 2.2s
T-29 (e34c7f7): 2.7s
T-28 (208671c): 2.1s
T-27 (909a22a): 2.9s
T-26 (881a185): 2.2s
T-25 (9036fc4): 2.5s
T-24 (d4393a8): 2.9s
T-23 (3212f41): 2.4s
T-22 (f303673): 2s
T-21 (4b53ea3): 2.7s
T-20 (2a674c3): 2s
T-19 (2c98796): 2.9s
T-18 (d15f50b): 2.6s
T-17 (cf43a33): 3.5s
T-16 (5c85398): 2.6s
T-15 (16e49d9): 2.6s
T-14 (47c0b97): 2.5s
T-13 (418a420): 3s
T-12 (bae1ee5): 2.8s
T-11 (a46048e): 2.7s
T-10 (ab24af6): 2.4s
T-9 (9012259): 2.5s
T-8 (419b090): 2.6s
T-7 (8ace0a8): 3.2s
T-6 (b615fbb): 3.6s
T-5 (c079d56): 3s
T-4 (0477b3e): 2.4s
T-3 (a2c3afd): 3.2s
T-2 (5ff3c49): 3.4s
T-1 (646c1cc): 2.5s
T (current commit): 3.4s

largeDepsNft: 11.6s

⬆️ 32.08% increase vs. 646c1cc

^                                                  11.7s                                           11.6s  
│                                                   ┌──┐                           11.1s            ┌──┐  
│                                          10.6s    |  |                   10.8s    ┌──┐            |▒▒|  
│                                           ┌──┐    |  |                    ┌──┐    |  |            |▒▒|  
│                                           |  |    |  |    9.5s            |  |    |  |            |▒▒|  
│ ──8.8s────8.9s────────────────────────────┼──┼────┼──┼────┌──┐────────────┼──┼────┼──┼────────────|▒▒|──
│   ┌──┐    ┌──┐                    8.4s    |  |    |  |    |  |            |  |    |  |            |▒▒|  
│   |  |    |  |    7.7s    7.6s    ┌──┐    |  |    |  |    |  |    7.4s    |  |    |  |    7.8s    |▒▒|  
│   |  |    |  |    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    ┌──┐    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (271729d): 7.8s
T-29 (e34c7f7): 10.6s
T-28 (208671c): 7.3s
T-27 (909a22a): 11s
T-26 (881a185): 8.2s
T-25 (9036fc4): 9.2s
T-24 (d4393a8): 10.9s
T-23 (3212f41): 8.7s
T-22 (f303673): 7.1s
T-21 (4b53ea3): 10s
T-20 (2a674c3): 6.9s
T-19 (2c98796): 10.6s
T-18 (d15f50b): 8.1s
T-17 (cf43a33): 12.1s
T-16 (5c85398): 8s
T-15 (16e49d9): 8.1s
T-14 (47c0b97): 8.1s
T-13 (418a420): 9.6s
T-12 (bae1ee5): 8.8s
T-11 (a46048e): 8.9s
T-10 (ab24af6): 7.7s
T-9 (9012259): 7.6s
T-8 (419b090): 8.4s
T-7 (8ace0a8): 10.6s
T-6 (b615fbb): 11.7s
T-5 (c079d56): 9.5s
T-4 (0477b3e): 7.4s
T-3 (a2c3afd): 10.8s
T-2 (5ff3c49): 11.1s
T-1 (646c1cc): 7.8s
T (current commit): 11.6s

largeDepsZisi: 22.2s

⬆️ 28.41% increase vs. 646c1cc

^                                                  22.5s                                           22.2s  
│                                                   ┌──┐                           21.5s            ┌──┐  
│                                                   |  |                   19.9s    ┌──┐            |▒▒|  
│                                          18.8s    |  |   19.1s            ┌──┐    |  |            |▒▒|  
│  17.8s                                    ┌──┐    |  |    ┌──┐            |  |    |  |            |▒▒|  
│ ──┌──┐───16.5s────────────────────────────┼──┼────┼──┼────┼──┼────────────┼──┼────┼──┼────────────|▒▒|──
│   |  |    ┌──┐                   15.6s    |  |    |  |    |  |            |  |    |  |   15.9s    |▒▒|  
│   |  |    |  |   14.8s   14.9s    ┌──┐    |  |    |  |    |  |   14.9s    |  |    |  |    ┌──┐    |▒▒|  
│   |  |    |  |    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (271729d): 15.4s
T-29 (e34c7f7): 19.8s
T-28 (208671c): 13.9s
T-27 (909a22a): 20.3s
T-26 (881a185): 15.3s
T-25 (9036fc4): 17s
T-24 (d4393a8): 20.4s
T-23 (3212f41): 17.4s
T-22 (f303673): 14.1s
T-21 (4b53ea3): 18.7s
T-20 (2a674c3): 14s
T-19 (2c98796): 20.5s
T-18 (d15f50b): 15.9s
T-17 (cf43a33): 22.5s
T-16 (5c85398): 16s
T-15 (16e49d9): 16s
T-14 (47c0b97): 16.2s
T-13 (418a420): 18.7s
T-12 (bae1ee5): 17.8s
T-11 (a46048e): 16.5s
T-10 (ab24af6): 14.8s
T-9 (9012259): 14.9s
T-8 (419b090): 15.6s
T-7 (8ace0a8): 18.8s
T-6 (b615fbb): 22.5s
T-5 (c079d56): 19.1s
T-4 (0477b3e): 14.9s
T-3 (a2c3afd): 19.9s
T-2 (5ff3c49): 21.5s
T-1 (646c1cc): 15.9s
T (current commit): 22.2s

Skn0tt · 2023-06-27T15:53:51Z

ha, @eduardoboucas you were right! windows support is the reason you went with the `ignoreFunction`. meh.

refactor: pass array to nft.ignore

1b859a4

Skn0tt requested a review from a team as a code owner June 27, 2023 15:45

Skn0tt closed this Jun 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: pass array to nft.ignore #1480

refactor: pass array to nft.ignore #1480

Skn0tt commented Jun 27, 2023 •

edited

github-actions bot commented Jun 27, 2023

Skn0tt commented Jun 27, 2023

	testMany('Ignore some excluded node modules', [...allBundleConfigs], async (options) => {
	const fixtureName = 'node-module-excluded'
	const opts = merge(options, {
	basePath: join(FIXTURES_DIR, fixtureName),
	})
	const { files } = await zipNode(fixtureName, { opts })

	await expect(`${files[0].unzipPath}/node_modules/aws-sdk`).not.toPathExist()

	try {
	const func = await importFunctionFile(`${files[0].unzipPath}/function.js`)

	func()

	expect.fail('Running the function should fail due to the missing module')
	} catch (error) {
	expect(error.code).toBe('MODULE_NOT_FOUND')
	}
	})

refactor: pass array to nft.ignore #1480

refactor: pass array to nft.ignore #1480

Conversation

Skn0tt commented Jun 27, 2023 • edited

Summary

github-actions bot commented Jun 27, 2023

⏱ Benchmark results

largeDepsEsbuild: 3.4s

largeDepsNft: 11.6s

largeDepsZisi: 22.2s

Skn0tt commented Jun 27, 2023

Skn0tt commented Jun 27, 2023 •

edited