This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: reinstate ESM transpilation for NFT #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
netlify-team-account-1
previously approved these changes
Nov 4, 2021
Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com>
Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com>
Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com>
netlify-team-account-1
approved these changes
Nov 4, 2021
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…#790) * feat: reinstate ESM transpilation for NFT * chore: add check for Node version * chore: add comment * chore: doh * chore: simplify Node version check Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com> * refactor: simplify Map initialisation Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com> * refactor: fix `shouldTranspile` * refactor: make `shouldTranspile` read from cache * refactor: use non-null assertion operator Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com> * refactor: remove non-null assertion operator Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Reinstates ESM transpilation when using NFT, which was temporarily disabled in #786. It's sitting behind a
nftTranspilefeature flag.Unlike the initial implementation introduced by #759, this PR only transpiles a file to ESM (and patches any corresponding
package.json) if all its parents are ESM files themselves, also candidates for transpilation.- Test plan
Existing tests adjusted accordingly.
- A picture of a cute animal (not mandatory but encouraged)