This repository has been archived by the owner on May 22, 2024. It is now read-only.
fix: compile away node:-namespaced imports
#806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
force-pushed
the
remove-node-prefix
branch
from
633e05f
to
35ac7d5
Compare
eduardoboucas
previously approved these changes
Nov 12, 2021
There was a problem hiding this comment.
LGTM. Can you change the description so that this doesn't close https://github.com/netlify/pod-serverless/issues/57? The issue is still there when not using esbuild.
eduardoboucas
approved these changes
Nov 12, 2021
Skn0tt
pushed a commit
that referenced
this pull request
Nov 15, 2021
this test was added as a very specific reproduction case, but since was superceded by two more general tests. Removed in a follow-up to #806.
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 15, 2021
this test was added as a very specific reproduction case, but since was superceded by two more general tests. Removed in a follow-up to #806. Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com>
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…-it#806) * chore: reproduce problem * fix: rewrite node:-imports on esbuild * chore: only require esbuild-compiled bundles * chore: require file for Node >= 14.18 * chore: gte wants a version, not an expression * chore: i should really run tests locally * chore: add test for cjs files, describe better * Update main.js Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com>
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
this test was added as a very specific reproduction case, but since was superceded by two more general tests. Removed in a follow-up to netlify/zip-it-and-ship-it#806. Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
AWS Lambda currently ships v14.17.4. Some libraries start using
require("node:..."), which was only added in v14.18. This PR updates our esbuild bundler, so that it "compiles away" thenode:prefix. The legacy / NFT logic behaviour is untouched.cc https://github.com/netlify/pod-serverless/issues/57
cc nuxt/nuxt#12764
- Test plan
- A picture of a cute animal (not mandatory but encouraged)