This repository has been archived by the owner on May 22, 2024. It is now read-only.
fix: only transpile ESM imports when entrypoint is ESM #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,10 @@ | |||
| class App { | |||
| constructor(event, context) { | |||
| return { | |||
There was a problem hiding this comment.
wait, what? Constructors can return something? this weird
There was a problem hiding this comment.
but fine for a fixture, I guess ^^
There was a problem hiding this comment.
The idea was to replicate this scenario, but using a class or not is actually irrelevant for the test case here. All that matters is that the file is ESM.
netlify-team-account-1
approved these changes
Nov 12, 2021
| @@ -0,0 +1,10 @@ | |||
| class App { | |||
| constructor(event, context) { | |||
| return { | |||
There was a problem hiding this comment.
but fine for a fixture, I guess ^^
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…t-and-ship-it#807) * fix: only transpile ESM imports when entrypoint is ESM * chore: fix tests * chore: fix test on Windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
The
shouldTranspilemethod was previously returningtruefor any path that doesn't have a parent, where in reality it must do so only if the path itself is an ESM file.- Test plan
A new test was added to verify this scenario.
- A picture of a cute animal (not mandatory but encouraged)