Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose minDurationPerAckExtension and exactlyOnceDeliveryEnabled #465

Merged
merged 5 commits into from May 5, 2023
Merged

expose minDurationPerAckExtension and exactlyOnceDeliveryEnabled #465

merged 5 commits into from May 5, 2023

Conversation

ChristianJohnston97
Copy link
Contributor

@ChristianJohnston97 ChristianJohnston97 commented Apr 4, 2023 •
edited

Please see this issue: #466

This PR exposes the field minDurationPerAckExtension and also the field exactlyOnceDeliveryEnabled which will automatically adjust minDurationPerAckExtension if it is not set.

Note that this is just for the grpc client. The http client will still have the same error detailed in the issue linked and will require a different solution.

@ChristianJohnston97 ChristianJohnston97 changed the title pubsub dependency upgrade expose minDurationPerAckExtension Apr 5, 2023
@ChristianJohnston97 ChristianJohnston97 changed the title expose minDurationPerAckExtension expose minDurationPerAckExtension and exactlyOnceDeliveryEnabled Apr 5, 2023
@ChristianJohnston97 ChristianJohnston97 mentioned this pull request Apr 6, 2023
Closed
chrisjl154
chrisjl154 approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@chrisjl154 chrisjl154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisjl154 chrisjl154 merged commit 1d63bfe into permutive-engineering:main May 5, 2023
@ChristianJohnston97 ChristianJohnston97 mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjl154 chrisjl154 chrisjl154 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChristianJohnston97 @chrisjl154