-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add customize content type parsers for api plugin #10449
feat: add customize content type parsers for api plugin #10449
Conversation
cd7825f
to
56abbb8
Compare
f5d6234
to
f609745
Compare
…t/async avvio issue
f609745
to
ae0e572
Compare
60a680e
to
7d608a2
Compare
Thanks for your PR @scott1028 I'm sorry no one got back to you sooner. We'll discuss this internally and see who can help move this forward |
Thanks for your reply :) |
@scott1028 I found someone who can look into this. He's busy with other things right now, but will get to this when he has some more time available |
Hey @scott1028 👋 Again sorry for the radio silence on this. I'll get to this one in the next day or two |
updated test. |
@scott1028 Thanks for your effort on this PR! We've been discussing this PR internally and have a couple of things I wanted to bring up.
|
@Tobbe Thanks for reply.
Need I work on this PR if you guys want to implement the same somehow?
hmm, I will name it something like |
No, nothing for you to do right now 🙂 We'll get back to you with how to move forward next week |
Sorry it's take me longer than expected to get to this. I'm going to look through this now. One thing that might help me understand better is where you had been planing on using this additional content parser within your project? |
@scott1028 and @Tobbe - I didn't have permission to push to your fork @scott1028 so I had to open a new PR in the redwood repo: #10573. This uses your original approach but just renames and moves things around a little. I'm happy with this approach until we decide we need to rework things in a more destructive way. @Tobbe might have naming or other decisions to make but I'd love to know what you think @scott1028 if this is okay and works for your problem? |
Yes. That's what I found the problem and I want to resolve after I surveyed fastify. :) |
It's great and works for me. Thanks. |
@Josh-Walker-GM can we close this in favor of your PR? |
yes. I think we can just use #10573 |
use #10573 |
Alterations to #10449 --------- Co-authored-by: scott1028 <mic1028002@gmail.com> Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com> Co-authored-by: David Thyresson <dthyresson@gmail.com>
Alterations to #10449 --------- Co-authored-by: scott1028 <mic1028002@gmail.com> Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com> Co-authored-by: David Thyresson <dthyresson@gmail.com>
This PR allows users to extend supported contentType for native API plugin.
I follow https://redwoodjs.com/docs/docker#using-the-server-file, but it doesn't work.
addContentTypeParser
doesn't work well afterawait register
fastify/fastify#5401