Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): exit on non-compilation Cargo errors, closes #3930 #3942

Merged
merged 8 commits into from Apr 22, 2022
Merged

fix(cli): exit on non-compilation Cargo errors, closes #3930 #3942

merged 8 commits into from Apr 22, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team April 22, 2022 03:34
@lucasfernog lucasfernog requested a review from a team as a code owner April 22, 2022 03:34
@lucasfernog lucasfernog requested a review from a team April 22, 2022 04:40
@lucasfernog lucasfernog merged commit b562288 into dev Apr 22, 2022
@lucasfernog lucasfernog deleted the fix/cli-dev-exit branch April 22, 2022 15:59
dceddia pushed a commit to dceddia/tauri that referenced this pull request May 14, 2022
@lucasfernog @dceddia
fix(cli): exit on non-compilation Cargo errors, closes tauri-apps#3930 (
4bd9c94 
tauri-apps#3942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lucasfernog