Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dialog open supports multiple dirs, fixes #4091 #4354

Merged
merged 4 commits into from Jun 15, 2022
Merged

fix: dialog open supports multiple dirs, fixes #4091 #4354

merged 4 commits into from Jun 15, 2022

Conversation

betamos
Copy link
Contributor

@betamos betamos commented Jun 15, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This requires no change to the dialog.open endpoint since multiple is an existing parameter.

@betamos betamos requested a review from a team June 15, 2022 20:22
@betamos betamos requested a review from a team as a code owner June 15, 2022 20:22
@lucasfernog lucasfernog merged commit 4e51dce into tauri-apps:dev Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@betamos @lucasfernog