Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sync webview theme with window theme on Windows, closes #5802 #5874

Merged
merged 5 commits into from Dec 27, 2022
Merged

fix: sync webview theme with window theme on Windows, closes #5802 #5874

merged 5 commits into from Dec 27, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Dec 19, 2022 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner December 19, 2022 22:56
@amrbashir amrbashir changed the title feat: sync webview theme with window theme on Windows, closes #5802 fix: sync webview theme with window theme on Windows, closes #5802 Dec 19, 2022
amrbashir
amrbashir commented Dec 19, 2022
View reviewed changes
core/tauri-runtime-wry/Cargo.toml
@@ -13,7 +13,7 @@ exclude = [ "CHANGELOG.md", "/target" ]
readme = "README.md"

[dependencies]
wry = { version = "0.23", default-features = false, features = [ "file-drop", "protocol" ] }
wry = { git = "https://github.com/tauri-apps/wry", default-features = false, features = [ "file-drop", "protocol" ] }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update to wry@0.24 when it is released and before this is merged.

@lucasfernog lucasfernog merged commit 7a8d570 into dev Dec 27, 2022
@lucasfernog lucasfernog deleted the sync-windows-theme branch December 27, 2022 17:57
luoffei pushed a commit to luoffei/tauri that referenced this pull request Dec 29, 2022
@amrbashir @lucasfernog @luoffei
fix: sync webview theme with window theme on Windows, closes tauri-ap…
f05880e 
…ps#5802 (tauri-apps#5874)

Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
@FlysoftBeta FlysoftBeta mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @lucasfernog