feat(core): implement new config structure #8723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
added a commit
to tauri-apps/plugins-workspace
that referenced
this pull request
Feb 1, 2024
|
One thing we talked about a few times which i completely forgot to mention in the rfc is to merge appimage deb rpm etc into a linux parent and dmg and app into a macos one to match the windows config. I honestly think this is really important. |
|
another one maybe? #8727 |
|
yeah seems like a good idea |
amrbashir
commented
Feb 1, 2024
lucasfernog
reviewed
Feb 2, 2024
lucasfernog
reviewed
Feb 2, 2024
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/cors@2.8.5, npm/express@4.18.2 |
|
does it make sense to rename AppUrl to FrontendDist too? Quite liked that about the prodFrontend variant. |
|
Also separated the enum variants so the JSON schema description is better (and the whole type makes more sense). |
|
That's better so maybe just change the name to |
|
|
|
I'll merge this one so we can move forward with the beta. If there's any changes left to do, we can do it in a separate PR. |
lucasfernog
approved these changes
Feb 3, 2024
lucasfernog
pushed a commit
to tauri-apps/plugins-workspace
that referenced
this pull request
Feb 3, 2024
* refactor(updater): accomodate to new tauri config restructure RFC#5 https://github.com/tauri-apps/rfcs/blob/f3e82a6b0c5390401e855850d47dc7b7d9afd684/texts/0005-tauri-config-restructure.md RFC#5 PR implementation: tauri-apps/tauri#8723 * lint and update configs
tauri-bot
pushed a commit
to tauri-apps/tauri-plugin-dialog
that referenced
this pull request
Feb 3, 2024
* refactor(updater): accomodate to new tauri config restructure RFC#5 https://github.com/tauri-apps/rfcs/blob/f3e82a6b0c5390401e855850d47dc7b7d9afd684/texts/0005-tauri-config-restructure.md RFC#5 PR implementation: tauri-apps/tauri#8723 * lint and update configs Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/7766772373 Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
tauri-bot
pushed a commit
to tauri-apps/tauri-plugin-notification
that referenced
this pull request
Feb 3, 2024
* refactor(updater): accomodate to new tauri config restructure RFC#5 https://github.com/tauri-apps/rfcs/blob/f3e82a6b0c5390401e855850d47dc7b7d9afd684/texts/0005-tauri-config-restructure.md RFC#5 PR implementation: tauri-apps/tauri#8723 * lint and update configs Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/7766772373 Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
tauri-bot
pushed a commit
to tauri-apps/tauri-plugin-updater
that referenced
this pull request
Feb 3, 2024
* refactor(updater): accomodate to new tauri config restructure RFC#5 https://github.com/tauri-apps/rfcs/blob/f3e82a6b0c5390401e855850d47dc7b7d9afd684/texts/0005-tauri-config-restructure.md RFC#5 PR implementation: tauri-apps/tauri#8723 * lint and update configs Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/7766772373 Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
tauri-bot
pushed a commit
to tauri-apps/tauri-plugin-websocket
that referenced
this pull request
Feb 3, 2024
* refactor(updater): accomodate to new tauri config restructure RFC#5 https://github.com/tauri-apps/rfcs/blob/f3e82a6b0c5390401e855850d47dc7b7d9afd684/texts/0005-tauri-config-restructure.md RFC#5 PR implementation: tauri-apps/tauri#8723 * lint and update configs Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/7766772373 Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC#5 https://github.com/tauri-apps/rfcs/blob/f3e82a6b0c5390401e855850d47dc7b7d9afd684/texts/0005-tauri-config-restructure.md
Closes #8055
Closes #8727