fix(build): ignore changes on autogenerated files #8736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lucasfernog
commented
Feb 2, 2024
lucasfernog
commented
- Writing to core/tauri/permissions is not a good idea, always triggers the build script to rerun
- rerun-if-changed should not be used for autogenerated permissions otherwise plugin build script always reruns
lucasfernog
changed the title
amrbashir
approved these changes
Feb 2, 2024
|
This is actually fine as long as we be careful not to always write the file (check if the contents changed first) and not rerun-if-changed it. That's why i'm keeping the autogenerated commands at the plugin crate itself and adding the reference markdown for each core plugin at #8737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.