New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): enhance app rerun-if-changed for capabilities and frontend dist #8756
Conversation
Would it be bad to simply print the rerun instruction with I think all the templates contain a file already so your way should work but if there is no file yet then adding one does still not trigger a rebuild. Maybe we call this more of an edge case idk, since as i said the v2 templates contain it and migrating from v1 to v2 causes a rebuild anyway. I just used an "empty" v2 beta project to test this and noticed it that way. Edit: hmmm i assume this wasn't done to prevent constant rebuilds if the folder doesn't exist :/ |
we can either assume the folder is there (it should) but i was also trying to support custom capability folder path which are possible via the tauri-build attributes |
i'll make a change to be smarter about it |
Pushed the same change for plugins (which does force a rebuild on the first local build since we now commit all autogenerated files). |
first local build after any permission change, but i think it's a good trade off between feature and DX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My test flow still doesn't reallyyy work but at least manually re-running tauri dev triggers a rebuild now and that's good enough, thanks for that :)
I have just updated to v2 in an existing application.
|
Spoke about this with @FabianLars ... currently we do not rerun the build script when a new capability file is created, leaving the app in a weird state where the permissions are not parsed and the user has no idea why. The idea was to move the schemas from
capabilities/schemas
togen/schemas
so we canrerun-if-changed=capabilities
.I'm also applying the same logic to the plugin permissions, which currently does not trigger a rebuild if a new permission is added.