feat(ipc): preserve channel message order #9070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
approved these changes
Mar 4, 2024
morajabi
reviewed
Mar 5, 2024
| // eslint-disable-next-line security/detect-object-injection | ||
| const message = this.#pendingMessages[pendingId] | ||
| // eslint-disable-next-line security/detect-object-injection | ||
| delete this.#pendingMessages[pendingId] |
There was a problem hiding this comment.
delete is advised against for performance reasons, you might consider setting it to null instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to preserve message order on tauri::ipc::Channel. It uses a counter that gets sent to the JavaScript side, which processes it and keeps an internal queue if needed.
This was raised on a Discord thread aiming to enhance usability of the websocket plugin.