Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync JVM flags with Trino defaults #164

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

nineinchnick
Copy link
Member

No description provided.

@nineinchnick nineinchnick requested a review from wendigo May 18, 2024 08:41
@cla-bot cla-bot bot added the cla-signed label May 18, 2024
@nineinchnick
Copy link
Member Author

As expected, older versions fail to run with:

Unrecognized VM option 'G1NumCollectionsKeepPinned=10000000'

I could add a condition on the image.tag, but when using custom-built images, it doesn't have to be a version number. It's not possible to specify a different app version when installing the chart, so we can't use this field.

Maybe we should consider removing the default JVM flags from the chart and rely on those in the image, unless explicitly set?

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the idea of removing the default config and relying on the docker container defaults. Users can still override it and we then have to just ensure its documented that you take the default from the container you use and update as desired.

@@ -32,6 +32,14 @@ data:
-Djdk.nio.maxCachedBufferSize=2000000
# Allow loading dynamic agent used by JOL
-XX:+EnableDynamicAgentLoading
{{/* only check the version number if the image is not overriden in any way */}}
{{- with .Values.image -}}
{{- if and (eq .repository "trinodb/trino") (not .useRepositoryAsSoleImageReference) (not .registry) (not .digest) (gt (default .Chart.AppVersion .tag | int ) 447 ) }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this on the Helm playground to make sure it works with arbitrary values in all the referenced fields.

@nineinchnick
Copy link
Member Author

I tried preparing another PR that would not override the default jvm.config but it's tricky, because we include values from the .Values.coordinator.jvm section. Handling this would require complex logic and IMO it's not worth it.

@nineinchnick nineinchnick merged commit 7e8ab2c into trinodb:main Jun 1, 2024
9 checks passed
@nineinchnick nineinchnick deleted the gc-workaround branch June 1, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants