Advanced test #165
Merged
Advanced test #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
force-pushed
the
advanced-test
branch
from
ac5cae4
to
3a10434
Compare
losipiuk
reviewed
May 21, 2024
test.sh
Outdated
Comment on lines
61
to
63
| ct install "${CT_ARGS[@]}" --helm-extra-set-args "$HELM_EXTRA_SET_ARGS" | ||
| ct install "${CT_ARGS[@]}" --helm-extra-set-args "$HELM_EXTRA_SET_ARGS --set server.workers=0" | ||
| ct install "${CT_ARGS[@]}" --helm-extra-set-args "$HELM_EXTRA_SET_ARGS --values test-values.yaml" |
There was a problem hiding this comment.
why these three configuration specifically?
There was a problem hiding this comment.
First one is for testing chart defaults.
Second one tests single-node deployments, which has a few conditions all over the chart.
The last one is a starting point for a test with most coverage.
losipiuk
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test more
values.yamlcombinations:values.yamlfile with as many features enabled as possible - this is the end goal, so far I added TLS, password auth and some access control rulesI moved the
custom-values.yamlfile to the root dir so it's more explicit and doesn't rely on some undocumented behavior ofchart-testing.All of this will allow us to ask contributors to test their changes by either updating
test-values.yamlor adding another test cases.