New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: conflicts and strip-dashed #1998
Merged
bcoe
merged 7 commits into
yargs:master
from
jly36963:fix-strip-dashed-and-conflicts-bug
Sep 7, 2021
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
44621ef
fix: conflicts and strip-dashed
jly36963 091ab32
fixes
jly36963 51c7be3
Merge branch 'master' into fix-strip-dashed-and-conflicts-bug
jly36963 2fed220
Merge branch 'master' into fix-strip-dashed-and-conflicts-bug
jly36963 0aa1df1
Merge branch 'master' into fix-strip-dashed-and-conflicts-bug
jly36963 9d1aa20
Merge branch 'master' into fix-strip-dashed-and-conflicts-bug
jly36963 a483741
fixes
jly36963 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
export function camelCase(s: string) { | ||
if (!s) return ''; | ||
// split camel case, then match ascii words | ||
const words = asciiWords(s.replace(/([a-z0-9])([A-Z])/g, '$1 $2')); | ||
return words.length > 1 | ||
? words[0].toLowerCase() + words.slice(1).map(capitalizeFirst).join('') | ||
: words[0].toLowerCase(); | ||
} | ||
|
||
function capitalizeFirst(word: string): string { | ||
return word ? word[0].toUpperCase() + word.slice(1).toLowerCase() : ''; | ||
} | ||
|
||
// eslint-disable-next-line no-control-regex | ||
const reAsciiWord = /[^\x00-\x2f\x3a-\x40\x5b-\x60\x7b-\x7f]+/g; | ||
|
||
function asciiWords(s: string) { | ||
return s.match(reAsciiWord) || []; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should have access to camelCase already through the yargs-parser dependency:
https://github.com/yargs/yargs-parser/blob/main/lib/string-utils.ts#L7
I believe I already use one or two methods off of it elsewhere.