Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused coveralls dependency #2326

Closed
wants to merge 2 commits into from

Conversation

shadowspawn
Copy link
Member

There are multiple warnings during npm install in this repo about stale dependencies that turn out to be due to coveralls.

For example:

$ npm install
...
npm WARN deprecated har-validator@5.1.5: this library is no longer supported


$ npm ls har-validator
yargs@17.7.2 /Users/john/Documents/Sandpits/yargs/my-yargs
└─┬ coveralls@3.1.1
  └─┬ request@2.88.2
    └── har-validator@5.1.5

coveralls was removed from the coverage workflow in #1578.

So remove coveralls as a dependency.

@bcoe
Copy link
Member

bcoe commented Jan 4, 2024

Did this in my cleanup of dependencies to get build passing.

@bcoe bcoe closed this Jan 4, 2024
@shadowspawn shadowspawn deleted the remove-coveralls branch January 4, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants