New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build)!: update typescript / eslint / rollup deps fixing bundling of yargs #2384
Conversation
For interest, there is a rollup org typescript plugin too. I tried switching to it due to targeting Node.js 14 at the time. Mentioning for interest as another option if encounter problems, and not a recommendation as such. |
@shadowspawn if your proposal is still passing, I'm open to a less drastic update where we move to Node 14 rather than 16. Which option do you prefer? |
I vote for Node.js 16, move forward (albeit still not to a version still in support). Multiple Yargs dependencies have dropped Node.js 14 and trying to support 14 is a pain point for maintenance. |
Looking for version related changes, there is a runtime check of Node.js version in cjs: Lines 16 to 18 in e517318
(There is not an equivalent check in esm, perhaps because the esm support in older versions is behind an experimental flag anyway!) |
Version related changes, there is a second reference to node version number which is still 14 in:
|
build(node)!: require Node >= 16.15.1
@shadowspawn Just dependency updates, but I'm always worried fiddling with build settings happy for additional eyes on review.
Note: the build tools now require Node 14 or greater, let's just update to Node 14 since 12 has been EOL for quite some time.
Note 2: had to pin and downgrade a couple build dependencies to make them work on Node 14, since the latest versions require Node 16.