add logs with request latency for json readData/metaData API #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
| @@ -239,11 +246,26 @@ private GoogleCloudStorageItemInfo fetchInitialMetadata() throws IOException { | |||
| RetryDeterminer.SOCKET_ERRORS, | |||
| IOException.class, | |||
| sleeper); | |||
|
|
|||
| logger.atFinest().log( | |||
| "GoogleCloudStorageReadChannel:getMetadata complete context:%d,time:%d,resource:%s,requestId:%s", | |||
There was a problem hiding this comment.
we don't need to log the class name GoogleCloudStorageReadChannel logging pattern have the fully qualified class name
| ? createFileNotFoundException(resourceId, e) | ||
| : new IOException("Error reading " + resourceId, e); | ||
| if (errorExtractor.itemNotFound(e)) { | ||
| throw createFileNotFoundException(resourceId, e); |
There was a problem hiding this comment.
We need to add a log here as well
| @@ -995,13 +1031,21 @@ protected InputStream openStream(long bytesToRead) throws IOException { | |||
| cacheFooter(response); | |||
| if (retriesCount != 0) { | |||
| logger.atInfo().log( | |||
| "Successfully cached footer after %s retries for '%s'", retriesCount, resourceId); | |||
| "Successfully cached footer context:%d,retries:%s,time:%d,resource:%s", | |||
| Thread.currentThread().getId(), | |||
There was a problem hiding this comment.
I don't think we need to log the threadId, it should already be part of the logging pattern (thread Id/name)
mprashanthsagar
suggested changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.