Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add buildbot_zisi_trace_nft feature flag #3765

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas commented Oct 25, 2021

Summary

Adds a buildbot_zisi_trace_nft feature flag and passes it to zip-it-and-ship-it as traceWithNft (see netlify/zip-it-and-ship-it#769).

It also concentrates all feature flag assertions via sinon into one test. These tests have to run with .serial, so the fewer we have, the better.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 25, 2021
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@eduardoboucas eduardoboucas merged commit f2ea534 into main Oct 26, 2021
@eduardoboucas eduardoboucas deleted the feat/trace-nft-flag branch October 26, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants