feat: emit schedule property into manifest
#768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netlify-team-account-1
added
the
type: feature
1 task
eduardoboucas
previously approved these changes
Oct 25, 2021
There was a problem hiding this comment.
LGTM. I thought it'd be a good idea to formally define the format of the manifest file, especially as other systems will start to consume it, so I've created #770.
eduardoboucas
changed the title
schedule property into manifestschedule property into manifest
|
@netlify-team-account-1 let's hold off on merging this until #760 is released (which is waiting for #769). |
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
⏱ Benchmark resultsComparing with 3c982bd largeDepsEsbuild: 9.3s⬆️ 16.69% increase vs. 3c982bd Legend
largeDepsZisi: 1m 18.4s⬆️ 18.92% increase vs. 3c982bd Legend
|
tests/main.js
Outdated
| @@ -2147,7 +2147,7 @@ if (platform !== 'win32') { | |||
| }) | |||
| } | |||
|
|
|||
| test.only('Creates a manifest file with the list of created functions if the `manifest` property is supplied', async (t) => { | |||
There was a problem hiding this comment.
@eduardoboucas should we have some lint rule against leaving those in? 😅
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Adds a new config field called
schedule, which is emitted into the functions manifest.TODO: mention in documentation.
- Test plan
added unit test.
- A picture of a cute animal (not mandatory but encouraged)